agl-developer opened a new pull request, #21172:
URL: https://github.com/apache/superset/pull/21172

   When adding a new database and selecting Snowflake, the database and account 
fields had the same placeholder. This PR adds a placeholder prop so values can 
be sent dynamically by field
   
   ### SUMMARY
   Adds an option to set a dynamic placeholder based on field.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before
   ![Clipboard 2022-12-05 at 4 33 08 
PM](https://user-images.githubusercontent.com/1985940/186277941-15e54df6-b6f3-4154-8cbf-5069dcb29a70.png)
   
   After
   ![Screenshot 2022-08-23 
162042](https://user-images.githubusercontent.com/1985940/186277737-5ab43b6d-dacf-4f7c-9376-c31ee348c8a2.png)
   
   
   ### TESTING INSTRUCTIONS
   - Click "Data" in the top nav and select "Databases"
   - Click the "+ Database" in the top right corner of the page
   - Select Snowflake database
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to