[GitHub] [superset] lyndsiWilliams opened a new pull request, #21189: feat: Create dataset header component

[GitBox]

lyndsiWilliams opened a new pull request, #21189:
URL: https://github.com/apache/superset/pull/21189

   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   This is the blank state implementation of the header component for the 
create dataset page. This PR also adds an option tooltip to the button in the 
`PageHeaderWithActions` component.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   #### BEFORE:
   <img width="1411" alt="layoutWithHeaderBefore" 
src="https://user-images.githubusercontent.com/55605634/186529329-c0e79f3f-f5d2-4151-87f3-6a930bf1f54c.png";>
   
   #### AFTER:
   <img width="1351" alt="layoutWithHeaderAfter" 
src="https://user-images.githubusercontent.com/55605634/186529361-bb8075c7-667d-40ca-a202-9d6c50dcb1e2.png";>
   <img width="1351" alt="headerAfter" 
src="https://user-images.githubusercontent.com/55605634/186529373-0f8cbb3a-fd32-491a-987e-63f0aeb68b85.png";>
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   - Go to `http://localhost:9000/dataset/add/?testing`
   - Observe the header component
   - Click the dataset name textbox and change the text by either pressing 
`enter` or clicking out of the box
     - Observe the text change
   - Mousehover over the disabled save and menu buttons on the left
     - Observe the tooltip
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org