rusackas commented on code in PR #21201:
URL: https://github.com/apache/superset/pull/21201#discussion_r955480654
##########
superset-frontend/src/featureFlags.ts:
##########
@@ -28,5 +28,13 @@ export function initFeatureFlags(featureFlags:
FeatureFlagMap) {
}
export function isFeatureEnabled(feature: FeatureFlag) {
- return window && window.featureFlags && !!window.featureFlags[feature];
Review Comment:
I think this is fine for this PR, but it seems like we should just be
importing the above Superset UI module everywhere and avoid having duplicate
code in the project. Maybe we can clean that up in some other PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
