Painyjames opened a new issue, #21207: URL: https://github.com/apache/superset/issues/21207
Hi, We are currently having some issues with SQL Lab permissions related to tables appearing in subselects. Our Superset users have datasource permissions that are evaluated when the execute a query in SQL Lab. Sql Lab uses the [ParsedQuery](https://github.com/apache/superset/blob/383313b105b0e82bea0f38cc971630eded5affe0/superset/sql_parse.py#L189) class to extract the tables on that query and then evaluates if a user can actually execute the query based on those permissions. Since [ParsedQuery](https://github.com/apache/superset/blob/383313b105b0e82bea0f38cc971630eded5affe0/superset/sql_parse.py#L335) excludes subselects from the table parsing mechanism, a user could hide a particular table that he/she doesn't have access to inside a subquery and get away with that. Our idea is to modify the ParsedQuery logic to actually include, or at least give the option to include, the subqueries when retrieving the tables involved in a query, would that be something sensible? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
