AAfghahi commented on code in PR #21213:
URL: https://github.com/apache/superset/pull/21213#discussion_r956210870
##########
superset-frontend/src/views/CRUD/data/database/DatabaseList.test.jsx:
##########
@@ -139,6 +139,10 @@ describe('DatabaseList', () => {
expect(wrapper.find(SubMenu)).toExist();
});
+ it('renders a SubMenu with no tabs', () => {
+ expect(wrapper.find(SubMenu).props().tabs).toBeUndefined();
Review Comment:
is undefined correct here or null?
##########
superset-frontend/src/views/CRUD/data/dataset/DatasetList.test.jsx:
##########
@@ -181,6 +182,14 @@ describe('DatasetList', () => {
wrapper.find('[data-test="bulk-select-copy"]').text(),
).toMatchInlineSnapshot(`"3 Selected (2 Physical, 1 Virtual)"`);
});
+
+ it('renders a SubMenu', () => {
+ expect(wrapper.find(SubMenu)).toExist();
+ });
+
+ it('renders a SubMenu with no tabs', () => {
+ expect(wrapper.find(SubMenu).props().tabs).toBeUndefined();
Review Comment:
same thought process here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
