justinpark opened a new pull request, #21240:
URL: https://github.com/apache/superset/pull/21240

   ### SUMMARY
   
   #13218 introduced a hook for api resources. The main purpose of the hook is 
for a state management for async api request and transformed a return data to a 
desired format. As @ktmud suggested, react-query includes these specs and also 
provides the global cache storage. 
   
   This commit introduces `react-query` to design a new api resource for tables 
query first.
   With the react-query hook, sqlLab can skip the duplicate request for table 
list on switching each tab. (And it can save the request table query in dataset 
configuration modal)
   
   After this commit merged, we can replace existing charts and database hooks 
by `react-query` too.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   -Before:
   
   
https://user-images.githubusercontent.com/1392866/187002976-b5e1cc85-c29e-4794-bece-a4393ff62098.mov
   
   - After:
   
   
https://user-images.githubusercontent.com/1392866/187002973-fa5c2a69-f828-4c1a-a7f5-cbc5edc9edaa.mov
   
   
   ### TESTING INSTRUCTIONS
   
   unit tests
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   cc: @suddjian 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to