lyndsiWilliams commented on code in PR #21189:
URL: https://github.com/apache/superset/pull/21189#discussion_r957876678
##########
superset-frontend/src/views/CRUD/data/dataset/AddDataset/Header/index.tsx:
##########
@@ -17,7 +17,85 @@
* under the License.
*/
import React from 'react';
+import { t, styled, css, SupersetTheme } from '@superset-ui/core';
+import { PageHeaderWithActions } from 'src/components/PageHeaderWithActions';
+import Button from 'src/components/Button';
+import Icons from 'src/components/Icons';
+import { Menu } from 'src/components/Menu';
+import { TooltipPlacement } from 'antd/es/tooltip';
+
+const editableTitleProps = {
+ title: '',
+ placeholder: 'Add the name of the dataset',
+ onSave: () => {},
+ canEdit: true,
+ label: 'dataset name',
+};
+
+const tooltipProps: { text: string; placement: TooltipPlacement } = {
+ text: 'Select a database table and create dataset',
+ placement: 'bottomRight',
+};
+
+const Styles = styled.div`
Review Comment:
Oh yeah good call, fixed in [`this
commit`](https://github.com/apache/superset/pull/21189/commits/890af00638acaa42d9f7d35bd86f3ad573739122).
##########
superset-frontend/src/views/CRUD/data/dataset/AddDataset/Header/index.tsx:
##########
@@ -17,7 +17,85 @@
* under the License.
*/
import React from 'react';
+import { t, styled, css, SupersetTheme } from '@superset-ui/core';
+import { PageHeaderWithActions } from 'src/components/PageHeaderWithActions';
+import Button from 'src/components/Button';
+import Icons from 'src/components/Icons';
+import { Menu } from 'src/components/Menu';
+import { TooltipPlacement } from 'antd/es/tooltip';
+
+const editableTitleProps = {
+ title: '',
+ placeholder: 'Add the name of the dataset',
+ onSave: () => {},
+ canEdit: true,
+ label: 'dataset name',
+};
+
+const tooltipProps: { text: string; placement: TooltipPlacement } = {
+ text: 'Select a database table and create dataset',
+ placement: 'bottomRight',
+};
+
+const Styles = styled.div`
+ .ant-btn {
+ span {
+ margin-right: 0;
+ }
+
+ &:disabled {
+ svg {
+ color: ${({ theme }) => theme.colors.grayscale.light1};
+ }
+ }
+ }
+`;
+
+const disabledSaveBtnStyles = (theme: SupersetTheme) => css`
Review Comment:
Also fixed in [`this
commit`](https://github.com/apache/superset/pull/21189/commits/890af00638acaa42d9f7d35bd86f3ad573739122).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
