dpgaspar commented on PR #21236:
URL: https://github.com/apache/superset/pull/21236#issuecomment-1231865499
> > Totally agree, this can probably be done without breaking anything
>
> @dpgaspar what would be your idea for implementing this without breaking
the existing configuration interface? A change of all variables to a common
`GUNICORN_*` prefix might break configurations that users currently applied via
the old environment variables.
>
> Offering backward compatibility for these options from my point of view
would require a lot of logic checking for the different variants and defining a
set of precedence rules for the different options.
>
> What was your idea?
Could be DRYer but something similar to:
``` bash
if [[ -z "${SERVER_WORKER_AMOUNT}" ]]; then
GUNICORN_WORKERS=${GUNICORN_WORKERS:-1}
elif [[ -z "${GUNICORN_WORKERS}" ]]; then
GUNICORN_WORKERS=${SERVER_WORKER_AMOUNT}
fi
echo ${GUNICORN_WORKERS}
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
