justinpark opened a new pull request, #21262: URL: https://github.com/apache/superset/pull/21262
### SUMMARY Since `max_tables` logic multiplies max_items by the current size, it always returns entire list. (i.e. `config["MAX_TABLE_NAMES"] = 1000` and `len(tables) = 40000` then `max_tables = 40000 * 1000 = 40,000,000) The previous logic also cuts out only if substr passed. This commit always follows the `MAX_TABLE_NAMES` for both cases. (must set MAX_TABLE_NAMES to 0 if full table list needed) ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A ### TESTING INSTRUCTIONS Set MAX_TABLE_NAMES to a small number Go to Sqllab and check the count of table list ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API cc: @john-bodley @ktmud -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
