Vadi commented on issue #5420: URL: https://github.com/apache/superset/issues/5420#issuecomment-1235076717
> The 2019-01-30 version of `CONTRIBUTING.md` does not mention anything about adding custom color schemes. Checked by searching for the keywords "color" and "scheme" on [the historic version of that file](https://github.com/apache/incubator-superset/blob/b70a9ae524ce4ec66695bbc62a0991d98e78e6df/CONTRIBUTING.md). > > The steps outlined in the OP seem to no longer be applicable following this change: [a7b52da](https://github.com/apache/superset/commit/a7b52da6ce801d3909a11e3c7497531ad96f2242). Moreover, no Markdown files were changed in #6234. > > So, what's the correct way to add a custom color scheme to Superset now? > Your code change seems right, but did you properly rebuild the js bundles and did you setup your dev environment properly? Read the CONTRIBUTING.md file for more information on setting up your dev env. I don > You can rebuild the js package by running the command. > > ```js > cd ${SUPERSET_HOME}/assets/ > ./js_build.sh > npm run dev > ``` This was not working, I ended up deleting docker volumes to make it work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
