[GitHub] [superset] gbusch opened a new pull request, #21323: fix(dashboard): padding between rows within tabs

GitBox Sun, 04 Sep 2022 10:19:19 -0700


gbusch opened a new pull request, #21323:
URL: https://github.com/apache/superset/pull/21323

*Note:* It's the same PR as #20366. However, there were some issues with
formatting and the pipelines (mainly because of lacking understanding on my
side). So for this few-lines change, I guess it is easier I open a new PR and
close the old one, rather than trying to fix the messed up old one...

## SUMMARY

There should be padding between rows in a dashboard. Before, this did not
work when the rows where within tabs. This is fixed here.
See this issue: #20303

## BEFORE SCREENSHOT

## AFTER SCREENSHOT

## TESTING INSTRUCTIONS

* Insert two charts into a new dashboard
* Add a filter. When hovering over a filter, the selection box shows some
space between the plots
* When you move the charts into tabs, there is no space between plots any
more (see first screenshot)
* AFTER APPLYING CHANGES FROM PR:
* Now there is also some space when the charts are within tabs (see second
screenshot).

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

[GitHub] [superset] gbusch opened a new pull request, #21323: fix(dashboard): padding between rows within tabs

Reply via email to