villebro commented on PR #21322: URL: https://github.com/apache/superset/pull/21322#issuecomment-1237175775
> Looking good. Would be nice to have tests and add some docs also. > > @villebro it feels like all these different excrypted_extra `Dict` keys can become hard to manage on the future, do you think adding some `TypedDict`s would improve it? @dpgaspar not a bad idea. Maybe we can do a standardization pass for 3.0 that makes these configs as uniform as possible across all specs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
