codyml commented on code in PR #20902:
URL: https://github.com/apache/superset/pull/20902#discussion_r964464022
##########
superset-frontend/src/explore/components/ExploreViewContainer/index.jsx:
##########
@@ -337,7 +375,7 @@ function ExploreViewContainer(props) {
}
function toggleModal() {
- setShowingModal(!showingModal);
+ props.actions.setSaveModalVisible(!props.isSaveModalVisible);
Review Comment:
I think this PR might be re-triggering the annoying bug that forced us to
[revert these two PRs](https://github.com/apache/superset/pull/20796):
https://user-images.githubusercontent.com/13007381/188811425-a306f8b2-4ec9-4aa1-94f7-504759ea1a6f.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
