[GitHub] [superset] ktmud commented on issue #21385: [SIP-88] Proposal for non-blocking SQL Lab persistence

Thu, 08 Sep 2022 12:11:28 -0700 


ktmud commented on issue #21385:
URL: https://github.com/apache/superset/issues/21385#issuecomment-1241120843

   I like this idea. Can you elaborate more on which states will be pulled to 
local storage and which states will be kept exclusively on remote? I'd imagine 
we probably shouldn't keep even a temporary local copy of big payloads such as 
query results.
   
   <img width="485" alt="image" 
src="https://user-images.githubusercontent.com/335541/189205958-31f8737e-ad17-4331-af85-a8d24f4b7061.png";>
   
   
   For states that can be loaded fresh upon page load--such as `tables` and 
`databases`, they should also be skipped for localStorage in this async 
approach.
   
   <img width="425" alt="image" 
src="https://user-images.githubusercontent.com/335541/189204207-ef8235a4-e979-4b17-b644-7fab0cadf901.png";>
   
   There are also some duplicates in saved states, too, that we may want to 
clean up:
   
   <img width="474" alt="image" 
src="https://user-images.githubusercontent.com/335541/189204753-f8853ae5-5fdb-493d-9c32-00bc55b33e0b.png";>
   
   I also noticed we are saving previous queries of current active tab even 
though they may never be used again. Should be able to save a lot of space if 
we just clean them up.
   
   ---
   
   To summarize, I think it'd be useful to start cleaning up current saved 
states when `SQLLAB_BACKEND_PERSISTENCE` is off, before migrating to this 
hybrid approach. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to