zhaoyongjie commented on code in PR #21441:
URL: https://github.com/apache/superset/pull/21441#discussion_r969525430
##########
tests/integration_tests/charts/data/api_tests.py:
##########
@@ -915,3 +915,67 @@ def test_chart_data_with_adhoc_column(self):
unique_genders = {row["male_or_female"] for row in data}
assert unique_genders == {"male", "female"}
assert result["applied_filters"] == [{"column": "male_or_female"}]
+
+
[email protected]()
+def physical_query_context(physical_dataset) -> Dict[str, Any]:
+ return {
+ "datasource": {
+ "type": physical_dataset.type,
+ "id": physical_dataset.id,
+ },
+ "queries": [
+ {
+ "columns": ["col1"],
+ "metrics": ["count"],
+ "orderby": [["col1", True]],
+ }
+ ],
+ "result_type": ChartDataResultType.FULL,
+ "force": True,
+ }
+
+
[email protected](
+ "superset.common.query_context_processor.config",
+ {
+ **app.config,
+ "CACHE_DEFAULT_TIMEOUT": 1234,
+ "DATA_CACHE_CONFIG": {
+ **app.config["DATA_CACHE_CONFIG"],
+ "CACHE_DEFAULT_TIMEOUT": None,
+ },
+ },
+)
+def test_cache_default_timeout(test_client, login_as_admin,
physical_query_context):
+ rv = test_client.post(CHART_DATA_URI, json=physical_query_context)
+ data = json.loads(rv.data.decode("utf-8"))
+ assert data["result"][0]["cache_timeout"] == 1234
Review Comment:
one non-blocking nit.
```python
assert rv.json["result"][0]["cache_timeout"] == 1234
```
##########
tests/integration_tests/charts/data/api_tests.py:
##########
@@ -915,3 +915,67 @@ def test_chart_data_with_adhoc_column(self):
unique_genders = {row["male_or_female"] for row in data}
assert unique_genders == {"male", "female"}
assert result["applied_filters"] == [{"column": "male_or_female"}]
+
+
[email protected]()
+def physical_query_context(physical_dataset) -> Dict[str, Any]:
+ return {
+ "datasource": {
+ "type": physical_dataset.type,
+ "id": physical_dataset.id,
+ },
+ "queries": [
+ {
+ "columns": ["col1"],
+ "metrics": ["count"],
+ "orderby": [["col1", True]],
+ }
+ ],
+ "result_type": ChartDataResultType.FULL,
+ "force": True,
+ }
+
+
[email protected](
+ "superset.common.query_context_processor.config",
+ {
+ **app.config,
+ "CACHE_DEFAULT_TIMEOUT": 1234,
+ "DATA_CACHE_CONFIG": {
+ **app.config["DATA_CACHE_CONFIG"],
+ "CACHE_DEFAULT_TIMEOUT": None,
+ },
+ },
+)
+def test_cache_default_timeout(test_client, login_as_admin,
physical_query_context):
+ rv = test_client.post(CHART_DATA_URI, json=physical_query_context)
+ data = json.loads(rv.data.decode("utf-8"))
+ assert data["result"][0]["cache_timeout"] == 1234
+
+
+def test_custom_cache_timeout(test_client, login_as_admin,
physical_query_context):
+ physical_query_context["custom_cache_timeout"] = 5678
+ rv = test_client.post(CHART_DATA_URI, json=physical_query_context)
+ data = json.loads(rv.data.decode("utf-8"))
+ assert data["result"][0]["cache_timeout"] == 5678
Review Comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
