kgabryje commented on PR #21438: URL: https://github.com/apache/superset/pull/21438#issuecomment-1245508879
> > Do we have an established pattern for 3-state feature flags? > > I'm not aware of one, and it might be worth mentioning that a lot of companies use feature flag manager platforms that prefer to work (or only work) with booleans. Booleans feel safer. I refactored it like this: `DASHBOARD_VIRTUALIZATION: Literal["NONE", "VIEWPORT", "PAGINATED"] = "NONE"`. It's available in redux state as `common.conf.DASHBOARD_VIRTUALIZATION`. We use a similar pattern with another config option: `DASHBOARD_AUTO_REFRESH_MODE: Literal["fetch", "force"] = "force"`. However, I'm also worried about potential problems with feature flag managers... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
