[GitHub] [superset] lukeasrodgers commented on pull request #8082: add GeoJSON encoding support to deck.gl Polygon chart

Tue, 13 Sep 2022 19:30:10 -0700 


lukeasrodgers commented on PR #8082:
URL: https://github.com/apache/superset/pull/8082#issuecomment-1246154113

   It seems like the support for multipolygons is still not quite working. 
   
   the following represents a multipolygon for CA FIPS code 06037
   
   ```
   { "type": "Feature", "properties": { "GEO_ID": "0500000US06037", "STATE": 
"06", "COUNTY": "037", "NAME": "Los Angeles", "LSAD": "County", "CENSUSAREA": 
4057.884000 }, "geometry": { "type": "MultiPolygon", "coordinates": [ [ [ [ 
-118.524531, 32.895488 ], [ -118.535823, 32.906280 ], [ -118.551134, 32.945155 
], [ -118.560887, 32.957891 ], [ -118.573522, 32.969183 ], [ -118.586928, 
33.008281 ], [ -118.596037, 33.015357 ], [ -118.606559, 33.014690 ], [ 
-118.605534, 33.030999 ], [ -118.594033, 33.035951 ], [ -118.575160, 33.033961 
], [ -118.569013, 33.029151 ], [ -118.564445, 33.024914 ], [ -118.564527, 
33.018637 ], [ -118.559171, 33.006291 ], [ -118.540069, 32.980933 ], [ 
-118.529228, 32.970921 ], [ -118.496811, 32.933847 ], [ -118.485288, 32.923545 
], [ -118.479039, 32.920363 ], [ -118.460623, 32.909510 ], [ -118.446771, 
32.895424 ], [ -118.369984, 32.839273 ], [ -118.353504, 32.821962 ], [ 
-118.356541, 32.817311 ], [ -118.360530, 32.819921 ], [ -118.379968, 32.824545 
], [ -118.387375
 , 32.825327 ], [ -118.394565, 32.823978 ], [ -118.401268, 32.820338 ], [ 
-118.425634, 32.800595 ], [ -118.429430, 32.805429 ], [ -118.428372, 32.806872 
], [ -118.444920, 32.820593 ], [ -118.476074, 32.841754 ], [ -118.487908, 
32.844590 ], [ -118.496298, 32.851572 ], [ -118.506902, 32.868503 ], [ 
-118.508095, 32.871321 ], [ -118.507193, 32.876264 ], [ -118.524641, 32.893175 
], [ -118.524531, 32.895488 ] ] ], [ [ [ -118.500212, 33.449592 ], [ 
-118.499669, 33.447879 ], [ -118.485570, 33.446213 ], [ -118.477646, 33.448392 
], [ -118.445812, 33.428907 ], [ -118.423576, 33.427258 ], [ -118.382037, 
33.409883 ], [ -118.370323, 33.409285 ], [ -118.368301, 33.407110 ], [ 
-118.365094, 33.388374 ], [ -118.324460, 33.348782 ], [ -118.316083, 33.342928 
], [ -118.310213, 33.335795 ], [ -118.303174, 33.320264 ], [ -118.305084, 
33.310323 ], [ -118.316787, 33.301137 ], [ -118.325244, 33.299075 ], [ 
-118.343249, 33.305234 ], [ -118.360332, 33.315330 ], [ -118.374768, 33.320065 
], [ -118.402941, 33.3209
 01 ], [ -118.440047, 33.318638 ], [ -118.456309, 33.321820 ], [ -118.465368, 
33.326056 ], [ -118.481886, 33.344123 ], [ -118.488770, 33.356649 ], [ 
-118.482609, 33.369914 ], [ -118.478465, 33.386320 ], [ -118.484949, 33.412131 
], [ -118.488750, 33.419826 ], [ -118.503952, 33.424234 ], [ -118.515914, 
33.422417 ], [ -118.516267, 33.425075 ], [ -118.523230, 33.430733 ], [ 
-118.537380, 33.434608 ], [ -118.558715, 33.433419 ], [ -118.563442, 33.434381 
], [ -118.570927, 33.439351 ], [ -118.575901, 33.448261 ], [ -118.593969, 
33.467198 ], [ -118.601185, 33.469853 ], [ -118.604030, 33.476540 ], [ 
-118.603375, 33.478098 ], [ -118.598783, 33.477939 ], [ -118.585936, 33.473819 
], [ -118.544530, 33.474119 ], [ -118.530702, 33.468071 ], [ -118.500212, 
33.449592 ] ] ], [ [ [ -118.633473, 34.269626 ], [ -118.636789, 34.291804 ], [ 
-118.650859, 34.320484 ], [ -118.796692, 34.616559 ], [ -118.881364, 34.790629 
], [ -118.894474, 34.817972 ], [ -118.881729, 34.817802 ], [ -118.877289, 
34.803212 ], [ -
 118.854576, 34.803027 ], [ -118.854253, 34.817772 ], [ -118.140074, 34.820780 
], [ -118.132940, 34.820739 ], [ -118.130847, 34.820938 ], [ -117.667292, 
34.822526 ], [ -117.667034, 34.558008 ], [ -117.660346, 34.557848 ], [ 
-117.658798, 34.440580 ], [ -117.650459, 34.339025 ], [ -117.646374, 34.289170 
], [ -117.677657, 34.165334 ], [ -117.677693, 34.164238 ], [ -117.711067, 
34.079536 ], [ -117.719481, 34.059731 ], [ -117.726010, 34.041128 ], [ 
-117.735846, 34.018554 ], [ -117.767752, 34.019429 ], [ -117.802539, 33.975551 
], [ -117.783287, 33.946411 ], [ -117.976498, 33.946050 ], [ -117.976530, 
33.928034 ], [ -117.976498, 33.919171 ], [ -117.976571, 33.911205 ], [ 
-117.976692, 33.910614 ], [ -117.976588, 33.909757 ], [ -117.976586, 33.906225 
], [ -118.011398, 33.873314 ], [ -118.028679, 33.873219 ], [ -118.058918, 
33.846121 ], [ -118.063268, 33.824220 ], [ -118.093008, 33.786289 ], [ 
-118.091970, 33.758472 ], [ -118.116703, 33.743549 ], [ -118.132698, 33.753217 
], [ -118.156900, 33.76
 0317 ], [ -118.175500, 33.763617 ], [ -118.180831, 33.763072 ], [ -118.187701, 
33.749218 ], [ -118.183700, 33.736118 ], [ -118.181367, 33.717367 ], [ 
-118.207476, 33.716905 ], [ -118.258687, 33.703741 ], [ -118.277208, 33.707091 
], [ -118.297104, 33.708319 ], [ -118.317205, 33.712818 ], [ -118.354705, 
33.732317 ], [ -118.360505, 33.736817 ], [ -118.385006, 33.741417 ], [ 
-118.396606, 33.735917 ], [ -118.411211, 33.741985 ], [ -118.428407, 33.774715 
], [ -118.423407, 33.782015 ], [ -118.405007, 33.800215 ], [ -118.394376, 
33.804289 ], [ -118.394307, 33.804315 ], [ -118.391507, 33.815415 ], [ 
-118.392107, 33.840915 ], [ -118.412708, 33.883913 ], [ -118.442410, 33.940312 
], [ -118.460611, 33.969111 ], [ -118.482729, 33.995912 ], [ -118.484212, 
33.997710 ], [ -118.502813, 34.015509 ], [ -118.519514, 34.027509 ], [ 
-118.543115, 34.038508 ], [ -118.569235, 34.041640 ], [ -118.603572, 34.039048 
], [ -118.609652, 34.036424 ], [ -118.668358, 34.038887 ], [ -118.675430, 
34.037479 ], [ -118.67
 9366, 34.033255 ], [ -118.706215, 34.029383 ], [ -118.732391, 34.032743 ], [ 
-118.744952, 34.032103 ], [ -118.783433, 34.021543 ], [ -118.787094, 34.019545 
], [ -118.805114, 34.001239 ], [ -118.821579, 34.013959 ], [ -118.840380, 
34.027527 ], [ -118.854653, 34.034215 ], [ -118.896159, 34.039207 ], [ 
-118.928048, 34.045847 ], [ -118.938081, 34.043383 ], [ -118.944887, 34.045340 
], [ -118.940965, 34.074830 ], [ -118.788889, 34.168214 ], [ -118.668152, 
34.168195 ], [ -118.667713, 34.240404 ], [ -118.632495, 34.240426 ], [ 
-118.633473, 34.269626 ] ] ] ] } }
   ```
   
   I believe it *should* look like this (see https://geojson.tools/)
   
   <img width="953" alt="Screen Shot 2022-09-13 at 10 28 01 PM" 
src="https://user-images.githubusercontent.com/816444/190045026-56889ea5-a226-4fc6-9694-c458452341ed.png";>
   
   
   but in preset (apologies if it's bad form for posting about preset instead 
of vanilla superset) it looks like this
   
   <img width="599" alt="Screen Shot 2022-09-13 at 10 27 07 PM" 
src="https://user-images.githubusercontent.com/816444/190045034-86fb4d59-ce1c-40b8-92e2-1131d60ba7d1.png";>
   
   it appears that the deck.gl polygon chart is just picking the first set of 
coordinates for the multipolygon and silently discarding the rest.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to