zhaoyongjie commented on code in PR #21464:
URL: https://github.com/apache/superset/pull/21464#discussion_r970657394
##########
superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/index.tsx:
##########
@@ -332,7 +332,7 @@ const time_grain_sqla: SharedControlConfig<'SelectControl'>
= {
const xAxis = controls?.x_axis;
const xAxisValue = xAxis?.value;
- if (xAxisValue === undefined || isAdhocColumn(xAxisValue)) {
+ if (isAdhocColumn(xAxisValue)) {
Review Comment:
Yes, it does. Line 329 returns true when FF is disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
