zhaoyongjie commented on code in PR #21378:
URL: https://github.com/apache/superset/pull/21378#discussion_r971086556
##########
superset/utils/core.py:
##########
@@ -1271,15 +1271,15 @@ def is_adhoc_column(column: Column) ->
TypeGuard[AdhocColumn]:
return isinstance(column, dict)
-def get_base_axis_column(columns: Optional[List[Column]]) ->
Optional[AdhocColumn]:
- if columns is None:
- return None
+def get_base_axis_label(columns: Optional[List[Column]]) -> Optional[str]:
Review Comment:
Good point, I have addressed these suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
