lyndsiWilliams commented on PR #21470: URL: https://github.com/apache/superset/pull/21470#issuecomment-1247406837
> @lyndsiWilliams per you comment, > > > There are actually pre-existing instances of paginated searching elsewhere in SQL Lab. Bringing this search functionality to the front end could get really expensive, could we re-enable server side searching? > > could you elaborate where this is used? Also when we (Airbnb) tried using the backend search functionality—augmenting our local environment—for fetching tables names we noticed the latency was unacceptable. > > cc: @justinpark I looked into this further and discussed with Elizabeth, we actually don't use server side searching for this and it isn't used elsewhere in SQL Lab like I thought. The table data isn't stored in our database, we fetch it from their db and it's a "reflection" of their database, not actually scanning rows in a database. So it should be fine to remove the server side searching after all 😁 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
