rusackas commented on PR #21474: URL: https://github.com/apache/superset/pull/21474#issuecomment-1248809841
> @rusackas Following feature flags are also missing. Can you please add them in this PR. > > DASHBOARD_EDIT_CHART_IN_NEW_TAB (@kgabryje) It's in the "In Testing" section > ENABLE_DND_WITH_CLICK_UX (@kgabryje) > ENABLE_EXPLORE_DRAG_AND_DROP (@kgabryje) These are in the "Stable" section > ENABLE_FILTER_BOX_MIGRATION (@graceguo-supercat) It's in the "In Testing" section > ESTIMATE_QUERY_COST (@betodealmeida) Unless I'm mistaken this is not a feature flag... but perhaps it should be, @betodealmeida ? > FORCE_DATABASE_CONNECTIONS_SSL (@AAfghahi) It's in the "Deprecated" section > USE_ANALAGOUS_COLORS (@stephenLYZ) > UX_BETA (@kgabryje) These are both in the "In Testing" section > I also suggest we should add one liner description in front of each feature flag to indicate what feature is hidden behind them. I can collect those descriptions from their original PR's and submit it as separate PR. What are your thoughts about this? I'd welcome that PR with open arms :) Ping me (or any of us on the thread) when it's ready for review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
