michael-s-molina opened a new pull request, #21496:
URL: https://github.com/apache/superset/pull/21496

   ### SUMMARY
   This PR rewrites the `ColorSchemeControl` component using Typescript and a 
functional component. The main reason for refactoring the component was that 
the previous version was re-rendering the `Select` component many times by 
mutating the `options` property when the user hovered the elements. This caused 
a bug in reordering the selected items when hovering in/out.
   
   ### TESTING INSTRUCTIONS
   We shouldn't have any function changes and the selected items should remain 
on top when hovering in/out.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to