mayurnewase opened a new pull request, #21501: URL: https://github.com/apache/superset/pull/21501
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> If value is null don't color it in table chart, will fix pivot table later if it has similar issue. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> Before:  After:  ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> 1. create virtual dataset with following query `SELECT 34523.323 as gmv, 24523.323 as fm, '1' as shem, '1' as gr UNION all SELECT 325323543.323 as gmv, 125323543.323 as fm, '2' as shem, '1' as gr UNION all SELECT null as gmv, 4764545.323 as fm, '3' as shem, '2' as gr UNION all SELECT -10 as gmv, 35254525.323 as fm, '4' as shem, '2' as gr` 2. create table chart with raw records, and from the customize tab set the custom color formatter on column`gmv` with condition `< 1` 3. test only colored cell is `-10` in `gmv` column. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: https://github.com/apache/superset/issues/21341 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
