eschutho opened a new pull request, #21523:
URL: https://github.com/apache/superset/pull/21523

   ### SUMMARY
   refactoring the extra json state in the database connection modal so that it 
is always serialized, as the api will expect it. Each component will 
deserialize and push it back to the reducer, which will then serialize it 
again. This should reduce some duplication of types and state. 
   
   This is also in preparation for adding a databricks form which will need to 
have extra json property as a field.
   
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   No visual changes
   
   ### TESTING INSTRUCTIONS
   Adding and removing extra json in the advanced section should work as 
expected
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to