zhaoyongjie commented on code in PR #21524:
URL: https://github.com/apache/superset/pull/21524#discussion_r974805516
##########
superset-frontend/src/dashboard/components/PropertiesModal/index.tsx:
##########
@@ -299,43 +299,48 @@ const PropertiesModal = ({
let colorNamespace = '';
let currentJsonMetadata = jsonMetadata;
- // color scheme in json metadata has precedence over selection
- if (currentJsonMetadata?.length) {
- let metadata;
- try {
- metadata = JSON.parse(currentJsonMetadata);
- } catch (error) {
- addDangerToast(t('JSON metadata is invalid!'));
- }
- currentColorScheme = metadata?.color_scheme || colorScheme;
- colorNamespace = metadata?.color_namespace || '';
-
- // filter shared_label_color from user input
- if (metadata?.shared_label_colors) {
- delete metadata.shared_label_colors;
- }
- if (metadata?.color_scheme_domain) {
- delete metadata.color_scheme_domain;
+ // validate currentJsonMetadata
+ let metadata;
+ try {
+ if (
+ !currentJsonMetadata.startsWith('{') ||
+ !currentJsonMetadata.endsWith('}')
+ ) {
+ throw new Error();
}
+ metadata = JSON.parse(currentJsonMetadata);
+ } catch (error) {
+ addDangerToast(t('JSON metadata is invalid!'));
+ return;
+ }
Review Comment:
Move the validated logic out of the `if clause`. Add `return` statement in
catch case,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
