jinghua-qa commented on PR #21241: URL: https://github.com/apache/superset/pull/21241#issuecomment-1256427978
> > Re-test in http://35.92.221.221:8080/, find an issue that the table list did not change with the search keyword: repo steps: 1, input keyword in the search box expect: table list will show match result with keyword actual: table list did not change > > Screen.Recording.2022-09-23.at.12.32.23.AM.mov > > Yes, I mentioned this a couple of comments above. Server side searching was disabled recently so currently the table search isn't working. I'll be fixing the search so that it uses client side searching in my next PR. Sorry have missed your previous comment, i think other than that i did not find other issues~ LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
