villebro commented on code in PR #21586:
URL: https://github.com/apache/superset/pull/21586#discussion_r979823622
##########
setup.py:
##########
@@ -114,11 +114,11 @@ def get_git_sha() -> str:
"redis",
"selenium>=3.141.0",
"simplejson>=3.15.0",
- "slackclient==2.5.0", # PINNED! slack changes file upload api in the
future versions
+ "slack_sdk>=3.1.1",
"sqlalchemy>=1.4, <2",
"sqlalchemy-utils>=0.38.3, <0.39",
"sqlparse==0.3.0", # PINNED! see
https://github.com/andialbrecht/sqlparse/issues/562
- "tabulate==0.8.9",
+ "tabulate>=0.8.9",
Review Comment:
..and here something similar, assuming typical semver?
```suggestion
"tabulate>=0.8.9, <0.9",
```
##########
setup.py:
##########
@@ -114,11 +114,11 @@ def get_git_sha() -> str:
"redis",
"selenium>=3.141.0",
"simplejson>=3.15.0",
- "slackclient==2.5.0", # PINNED! slack changes file upload api in the
future versions
+ "slack_sdk>=3.1.1",
Review Comment:
Can we add a `,4` here, just in case?
```suggestion
"slack_sdk>=3.1.1, <4",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
