[GitHub] [superset] geido commented on pull request #21560: feat: Adds the MetadataBar to the Explore header

Mon, 26 Sep 2022 08:00:04 -0700 


geido commented on PR #21560:
URL: https://github.com/apache/superset/pull/21560#issuecomment-1258170525

   Hey @michael-s-molina a few quick comments from a first look
   
   Should we add a placeholder text when there are no available owners?
   
   ![Screenshot 2022-09-26 at 17 46 
53](https://user-images.githubusercontent.com/60598000/192308010-376b7f55-bdb6-44ea-bef1-a343fab7fe26.png)
   
   Spacing requires some improvement
   
   ![Screenshot 2022-09-26 at 17 51 
09](https://user-images.githubusercontent.com/60598000/192309169-dcc4a961-d894-406f-8070-4a38f19a919b.png)
   
   Can we make the empty space equal on both ends?
   
   ![Screenshot 2022-09-26 at 17 53 
53](https://user-images.githubusercontent.com/60598000/192309872-b064ebe9-2626-4d5b-9d2b-73a773ba6f8f.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to