zhaoyongjie opened a new pull request, #21642:
URL: https://github.com/apache/superset/pull/21642

   ### SUMMARY
   This is a quick fix that should apply time grain when Generic Axis is 
enabled. The Power Query should get more consideration and code design in the 
future so that share the same unit test and codebase with 
`connections.model.sqla` and logic.
   
   
   The column in the` X-Axis` control is designed as a time column when 
`Generic Axis` is enabled. The `Time Grain` control should apply a time 
truncation function to the `X-Axis` column. This feature has been implemented 
in the **virtual dataset** and the **physical dataset** but can't use in Power 
Query mode.
   
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   #### Before
   
   
   
https://user-images.githubusercontent.com/2016594/192987619-c7f948eb-1051-44f6-a180-8fd70c19cd4b.mov
   
   
   
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to