eschutho commented on code in PR #21570:
URL: https://github.com/apache/superset/pull/21570#discussion_r983829105
##########
superset/db_engine_specs/bigquery.py:
##########
@@ -396,10 +396,12 @@ def get_parameters_from_uri(
raise ValidationError("Invalid service credentials")
@classmethod
- def mask_encrypted_extra(cls, encrypted_extra: str) -> str:
+ def mask_encrypted_extra(
+ cls, encrypted_extra: Union[str, None]
+ ) -> Union[str, None]:
try:
- config = json.loads(encrypted_extra)
- except json.JSONDecodeError:
+ config = json.loads(encrypted_extra) # type:ignore
Review Comment:
Thanks for the suggestion. Yeah I think it looks better this way without the
type ignores. I also left the TypeError in the except block just in case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
