[GitHub] [superset] justinpark opened a new pull request, #21667: fix(sqllab): async query broken due to #21320

[GitBox]

justinpark opened a new pull request, #21667:
URL: https://github.com/apache/superset/pull/21667

   ### SUMMARY
   This commit fixes the async query broken issue on #21656
   
   In #21320, it updated the following code 
   
   ```diff
   ---624      runQuery={this.runQuery}
   +++540      runQuery={startQuery}
   ```
   which executes `startQuery` with empty args.
   ```
   /// 422
     runQuery() {
       if (this.props.database) {
         this.startQuery();
       }
     }
   ```
   This different payload broke the async query request.
   This commit reverts back this origin logic.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   - Before
   
   <img width="762" alt="Screen Shot 2022-09-30 at 2 00 34 PM" 
src="https://user-images.githubusercontent.com/1392866/193357024-750e5c58-487f-4060-850f-2069c84baf1a.png";>
   
   - After
   
   <img width="780" alt="Screen Shot 2022-09-30 at 2 00 59 PM" 
src="https://user-images.githubusercontent.com/1392866/193357014-e2f0f888-5712-4ac1-bbc6-2f4f94defbc7.png";>
   
   ### TESTING INSTRUCTIONS
   enable database option to async query execution
   run the query
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org