kgabryje opened a new pull request, #21683: URL: https://github.com/apache/superset/pull/21683
### SUMMARY 1. "Add a dataset" link in AddSlice page - instead of opening in a new tab, use SPA navigation to open dataset creation modal in the same tab. 2. "Add dataset and create chart" button in dataset creation modal - use SPA navigation to open AddSlice page with new dataset preselected ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF https://user-images.githubusercontent.com/15073128/193597550-e59656fe-400c-4eb5-a2fb-74a6b538f066.mov ### TESTING INSTRUCTIONS 1. Open AddSlice page and click "Add a dataset" 2. Verify that datasets page with dataset creation modal opens in the same tab 3. Verify that clicking back button navigates back to AddSlice page 4. Verify that creating a dataset opens AddSlice page with the new dataset preselected 5. Cmd + click "Add a dataset" to open dataset creation page in a new tab and repeat steps 2-4. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
