Antonio-RiveroMartnez opened a new pull request, #21709:
URL: https://github.com/apache/superset/pull/21709

   ### SUMMARY
   At some point we stopped handling and displaying API errors coming as raw 
strings in the DatabaseModal. We are bringing that back, so for example, if 
someone tries to connect a BigQuery DB using credential JSON files with no 
roles in it, an error gets displayed vs no indication at all.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   
![error](https://user-images.githubusercontent.com/38889534/194174126-697cfc81-2e8e-41d8-940d-52dbf0243089.gif)
   
   After:
   
![test](https://user-images.githubusercontent.com/38889534/194174150-879db5fb-0d3f-429f-9212-82f2b9e7a4bc.gif)
   
   
   ### TESTING INSTRUCTIONS
   Create a new Service Account on Google Console. Doesn’t grant any Role to it.
   Download the Service Account key via jSON.
   Access your Workspace.
   Hover over the + on the top right corner, then navigate to Data > Connect 
database.
   Select Google BigQuery.
   Click on Choose File to upload the JSON.
   Click on CONNECT.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to