michael-s-molina commented on code in PR #21685:
URL: https://github.com/apache/superset/pull/21685#discussion_r989275506
##########
superset-frontend/src/explore/components/useExploreAdditionalActionsMenu/index.jsx:
##########
@@ -246,14 +249,25 @@ export const useExploreAdditionalActionsMenu = (
openKeys={openSubmenus}
onOpenChange={setOpenSubmenus}
>
- {slice && (
- <>
+ <>
+ {slice && (
<Menu.Item key={MENU_KEYS.EDIT_PROPERTIES}>
{t('Edit chart properties')}
</Menu.Item>
- <Menu.Divider />
- </>
- )}
+ )}
+ {isFeatureEnabled(FeatureFlag.CROSS_REFERENCES) && (
Review Comment:
The design specification shows the "Dashboards added to" with a `None` item.
I think this is intentional to present the user with the same experience when
there's no dashboard associated whether is a new chart or a saved one.
<img width="442" alt="Screen Shot 2022-10-06 at 1 43 13 PM"
src="https://user-images.githubusercontent.com/70410625/194371000-b1fa250f-1f77-4842-b9d4-0917ec5b9bc1.png";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/70410625/194371000-b1fa250f-1f77-4842-b9d4-0917ec5b9bc1.png"](https://user-images.githubusercontent.com/70410625/194371000-b1fa250f-1f77-4842-b9d4-0917ec5b9bc1.png"){kind=link}