Antonio-RiveroMartnez commented on code in PR #21710:
URL: https://github.com/apache/superset/pull/21710#discussion_r989637490
##########
superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx:
##########
@@ -744,7 +746,10 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps>
= ({
});
}
- setDB({ type: ActionType.addTableCatalogSheet });
+ if (database_name === 'Google Sheets') {
Review Comment:
Shouldn't this be checking for the engine/backend instead of the DB Name
which might be changed by users?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
