villebro commented on code in PR #21319:
URL: https://github.com/apache/superset/pull/21319#discussion_r989736397
##########
superset-frontend/packages/superset-ui-switchboard/src/switchboard.ts:
##########
@@ -90,7 +90,7 @@ function isError(message: Message): message is ErrorMessage {
export class Switchboard {
port: MessagePort;
- name: string;
+ name = '';
Review Comment:
Is this change needed? I feel like the previous one was cleaner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]