michael-s-molina commented on code in PR #21650:
URL: https://github.com/apache/superset/pull/21650#discussion_r990520312
##########
superset-frontend/src/SqlLab/components/SqlEditorLeftBar/SqlEditorLeftBar.test.jsx:
##########
@@ -58,7 +52,16 @@ fetchMock.get('glob:*/superset/tables/**', {
tableLength: 1,
});
+const setup = (props, store) =>
+ render(<SqlEditorLeftBar {...props} />, {
+ useRedux: true,
+ ...(store && { store }),
+ });
+
describe('Left Panel Expansion', () => {
+ const renderAndWait = (props, store) =>
Review Comment:
There are some unnecessary uses of the await keyword in the tests. I created
a patch file with some changes. To use it you need to uncompress the file and
`git apply tests.patch`
[tests.patch.zip](https://github.com/apache/superset/files/9737632/tests.patch.zip)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
