justinpark opened a new pull request, #21741:
URL: https://github.com/apache/superset/pull/21741

   ### SUMMARY
   Since the rendering refactoring by #20877, the number of redundant rendering 
reduced.
   The FilterableTable re-rendering reduced related to the unnecessary property 
update but it wasn't reloaded when height is updated. This occurs the empty 
result-set problem due to react-virtualized rendering issue with `NaN` height 
value.
   
   This commit fixes the rendering issue with the updated height value.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   - Before
   
   
https://user-images.githubusercontent.com/1392866/194672139-106af5f1-718f-44a4-a3a4-f70433f53642.mov
   
   - After
   
   
https://user-images.githubusercontent.com/1392866/194672137-58aa31ed-6b9d-4aac-b123-a26eb81df189.mov
   
   ### TESTING INSTRUCTIONS
   - Go to SqlLab
   - Open 2 tabs in UI
   - Run query in 1 and wait for results to show
   - Switch to other tab, then back to original tab
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to