codyml opened a new pull request, #21744: URL: https://github.com/apache/superset/pull/21744
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> PR #21544 was a fix for something I broke in #21315. This PR adds unit tests for the `getControlValuesCompatibleWithDatasource` module, used when the datasource is switched in Explore to keep valid control values, that would have caught this bug. ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> - All tests should pass. - Cherry-picking this commit onto b36bd3f083d0b2c125f472c23caa39b035ee5f27, the commit before #21544 was merged, and run tests again. One should fail. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
