zhaoyongjie commented on code in PR #21760:
URL: https://github.com/apache/superset/pull/21760#discussion_r992341075
##########
superset-frontend/src/views/CRUD/chart/ChartList.tsx:
##########
@@ -135,6 +137,47 @@ const createFetchDatasets = async (
};
};
+const createFetchDashboards = async (
+ filterValue = '',
+ page: number,
+ pageSize: number,
+) => {
+ // add filters if filterValue
+ const filters = filterValue
+ ? { filters: [{ col: 'dashboards', opr: FilterOperator.relationManyMany,
value: filterValue }] }
+ : {};
+ const queryParams = rison.encode({
+ columns: ['dashboard_title', 'id'],
+ keys: ['none'],
+ order_column: 'dashboard_title',
+ order_direction: 'asc',
+ page,
+ page_size: pageSize,
+ ...filters,
+ });
+ const { json = {} } = await SupersetClient.get({
Review Comment:
We should have processed HTTP error in every quest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
