villebro commented on PR #21765: URL: https://github.com/apache/superset/pull/21765#issuecomment-1279679663
> Thanks for the updates, this is looking great!! > > > > One thing I noticed for the Alpha user - when they try to save changes on a report that they don't own, they see a toast with this message: > > An error occurred while fetching reports: "Forbidden" > > > > I think the buttons on the modal should be hidden (or disabled)... or if that's not doable we should at least update the toast message to clarify to the user why the save failed. I noticed the same (there's also an annoying pluralization on the model name, making it "Reportss" 😄 I checked that fixing these is slightly more work than I have time for now, but I'll try to find time to fix these in a follow up PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
