GerbenvdHuizen opened a new pull request, #21850: URL: https://github.com/apache/superset/pull/21850
### SUMMARY he views for uploading data files (csv, excel etc.) to a database have form options to pass and/or infer `datetime` columns. However, the hive `df_to_sql` method does not support storing `datetime` columns as TIMESTAMPs in the Hive schema. It would be a nice for the `_get_hive_type` functionality to at least support the basic `datetime64[ns]` dtype. ### TESTING INSTRUCTIONS The following steps require you to be able to upload files to a schema on Superset (`allow_file_upload`) + use Hive as DB engine. Steps: 1. Upload a csv with an inferable timestamp: ``` test_column,timestamp something,2022-01-01T01:01:01.000000 ``` 2. Make sure `parse_dates` is set to the timestamp column in your csv file and `infer_datetime_format` is set to true within the form. 3. Submit the CSV and confirm that the new table has a column with type TIMESTAMP. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
