john-bodley commented on code in PR #21815:
URL: https://github.com/apache/superset/pull/21815#discussion_r998555506
##########
superset/config.py:
##########
@@ -466,7 +466,6 @@ def _try_json_readsha(filepath: str, length: int) ->
Optional[str]:
"EMBEDDABLE_CHARTS": True,
"DRILL_TO_DETAIL": False,
"DATAPANEL_CLOSED_BY_DEFAULT": False,
- "CROSS_REFERENCES": False,
Review Comment:
Is the preferred strategy to first enable the `CROSS_REFERENCES` feature by
default and then deprecate the feature in version 3.0?
Also [SIP-57](https://github.com/apache/superset/issues/12566) changing the
default or removing a feature flag is deemed a breaking change and thus the
appropriate actions need to be undertaken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
