simonvanderveldt opened a new issue, #21888:
URL: https://github.com/apache/superset/issues/21888
When a query times out it's status is written as failed into the Superset
database, this makes it impossible/difficult to distinguish timeouts from
actual failures (i.e. issue in the query, crash of the SQL engine, etc).
Also `end_time` isn't set for timed out queries, making reporting on query
runtimes incorrect, since the longest running ones (the ones that time out)
can't be counted.
We use the query status as well as the runtimes (which we have to derive
from by subtracting start_time from end_time) from the Superset database to
monitor how well our Superset + SQL environment is doing. The lack of a
dedicated status for timeouts makes it difficult to get an overview of how many
queries are timing out.
The lack of an end_time for timed out queries means our reporting heavily
skewed because the runtimes of the longest running queries can't be included in
the reporting.
#### How to reproduce the bug
- Run a query that times out
- Check in the `query` table of the Superset database and notice that it's
`status` column has the value `failed` instead of `timeout` (or `timed out`,
whatever you prefer) and `end_time` isn't set
### Expected results
- `status` is set to `timeout` when a query times out
- `end_time` is set when a query times out
### Actual results
- `status` is set to `failed`
- `end_time` isn't set
### Environment
- Superset version: 2.0.0 (we're using the `apache/superset:2.0.0` Docker
image)
- In case it matters we're using Spark Thriftserver as our SQL engine
```
FEATURE_FLAGS = {
"SQLLAB_BACKEND_PERSISTENCE": True,
"ENABLE_TEMPLATE_PROCESSING": True,
"ENABLE_TEMPLATE_REMOVE_FILTERS": True,
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]