[GitHub] [superset] codyml opened a new pull request, #21894: fix(dashboard): Ensure correct positioning of drill to detail submenu

[GitBox]

codyml opened a new pull request, #21894:
URL: https://github.com/apache/superset/pull/21894

   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   The "Drill to detail by" context menu submenu introduced in #21351 can end 
up offscreen, if there are enough menu items and you right-click close to the 
bottom of the viewport.  This PR uses the logic that currently handles that 
issue with the top-level context menu to also handle the issue for the submenu.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   Before:
   <img width="947" alt="Screen Shot 2022-10-20 at 3 12 59 PM" 
src="https://user-images.githubusercontent.com/13007381/197059380-b8198c3a-ef33-4d38-9697-06a3008f02a7.png";>
   
   After:
   <img width="955" alt="Screen Shot 2022-10-20 at 3 13 27 PM" 
src="https://user-images.githubusercontent.com/13007381/197059420-85b573d9-c9ee-4559-8586-ef41127f4272.png";>
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   1. Run Superset with `DRILL_TO_DETAIL` set to `True`.
   2. Create a dashboard full of time-series bar charts with > 1 dimension.
   3. Try opening the drill to detail context menu all over the chart.  Submenu 
placement should be the default Y-position (slightly lower than the parent 
item) everywhere except near the bottom edge.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org