lyndsiWilliams commented on code in PR #21893:
URL: https://github.com/apache/superset/pull/21893#discussion_r1001989641
##########
superset-frontend/src/views/CRUD/data/dataset/AddDataset/DatasetPanel/index.tsx:
##########
@@ -17,16 +17,45 @@
* under the License.
*/
import React from 'react';
-import { t, styled } from '@superset-ui/core';
+import { supersetTheme, t, styled } from '@superset-ui/core';
+import Icons from 'src/components/Icons';
import { EmptyStateBig } from 'src/components/EmptyState';
+type DatasetPanelProps = {
+ tableName?: string | null | undefined;
Review Comment:
Actually, this prop is `null` when a table isn't selected so I added it to
the type in this
[`commit`](https://github.com/apache/superset/pull/21893/commits/eb9a0d84c625fbbe98b7e9581aef9606ca6aea9e).
Undefined wasn't needed here though, so still a good call, thanks! 😁
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
