pkdotson commented on code in PR #21899:
URL: https://github.com/apache/superset/pull/21899#discussion_r1002237232
##########
superset-frontend/src/SqlLab/components/SqlEditor/index.jsx:
##########
@@ -219,6 +219,7 @@ const SqlEditor = ({
if (latestQuery && ['running', 'pending'].indexOf(latestQuery.state) >= 0)
{
dispatch(postStopQuery(latestQuery));
}
+ return false;
Review Comment:
yes to prevent the event from bubbling up. This is for the stopquery fn.
Mousetrap sometime recommends this.
##########
superset-frontend/src/SqlLab/components/SqlEditor/index.jsx:
##########
@@ -219,6 +219,7 @@ const SqlEditor = ({
if (latestQuery && ['running', 'pending'].indexOf(latestQuery.state) >= 0)
{
dispatch(postStopQuery(latestQuery));
}
+ return false;
Review Comment:
yes to prevent the event from bubbling up. This is for the stopquery fn.
Mousetrap sometimes recommends this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
