john-bodley opened a new pull request, #21936: URL: https://github.com/apache/superset/pull/21936
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY We (Airbnb) has a user report an error where in SQL Lab a query would run for infinitum when the row limit was increased. The issue was the Celery worker crashed with the following error: ``` WorkerLostError: Worker exited prematurely: signal 9 (SIGKILL). ``` It turns out the root cause was a call to `numpy.vectorize` function which per [here](https://stackoverflow.com/questions/7078371/how-to-avoid-enormous-additional-memory-consumption-when-using-numpy-vectorize) can consume copious amounts of memory. The `numpy.vectorize` function is only used once in the code base, and though there may be some slowdown, the fix was merely to un-vectorize the logic using a iterator per the Numpy [documentation](https://numpy.org/doc/stable/reference/arrays.nditer.html#modifying-array-values). <!--- Describe the change below, including rationale and design decisions --> ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS CI. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
