[GitHub] [superset] justinpark opened a new pull request, #21937: fix: BIGINT rendering regression in chartAction

[GitBox]

justinpark opened a new pull request, #21937:
URL: https://github.com/apache/superset/pull/21937

   ### SUMMARY
   Since chart data api `/api/v1/chart/data` responds the bigint in number 
format, the number beyond the JS limit that are replaced with the special 
number.
   This commit adds the bigint parser for chart data request to fix the 
unmatched value displaying.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Before:
   
   <img width="1017" alt="Screen Shot 2022-10-25 at 12 37 20 PM" 
src="https://user-images.githubusercontent.com/1392866/197882374-ee133f06-bbc1-4e26-a481-b7b3018a7589.png";>
   
   After:
   
   <img width="1022" alt="Screen Shot 2022-10-25 at 12 38 33 PM" 
src="https://user-images.githubusercontent.com/1392866/197882371-c1870d91-23f7-4ba2-9b97-6c35c70ecdfe.png";>
   
   
   ### TESTING INSTRUCTIONS
   - Go to sqllab and then make a simple query with a big number like `SELECT 
568485382077428896 as BIGNUM`
   - Save dataset and then explore to a table chart
   - set query mode to Raw and then check the result
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   cc: @john-bodley @ktmud 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org