Yann-J commented on PR #21458: URL: https://github.com/apache/superset/pull/21458#issuecomment-1294689305
Hey FYI @benjaminrene I just noticed this PR, I think it's superseded by #21806 (which also includes other improvements such as more configurable probes and support for a `flower` UI). It doesn't have some of the automatic Python config that your PR has... I think those are easy enough to pass separately as overrides, and I'm a bit cautious about forcing too many assumptions in the config - e.g. one may want to enabled websockets and set `GLOBAL_ASYNC_QUERIES_TRANSPORT=ws` in `superset_config.py`, but not use the Chart's deployment to run the websocket server... or craft their own `GLOBAL_ASYNC_QUERIES_WEBSOCKET_URL` that doesn't depend on the ingress settings (e.g. in my organization we don't use any chart's built-in ingresses because we maintain our own with a special security and approval process). Unfortunately that PR was merged but the helm release process seems broken - #21963 will hopefully fix this. I've also seen your PR #21379 which I'm also looking forward to! FYI you might be interested to look into #21954 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
